Any PHP Guru's?

DY357LX · January 2011

<div class="IPBDescription">Why Aren't My PNG's Generating Thumbnails?</div>NOTE: If the code below is too long let me know and I'll put it on a pastebin page to make the post easier on the eyes.

I <a href="http://www.youtube.com/watch?v=W2-kS1TWBfU" target="_blank">followed this tutorial</a> and I've been using EasyGallery.php to display a folder of images and it's been working fine until I realized that it was only generating thumbnails for .jpg files.

(Script: <a href="http://www.freitagmorgen.de" target="_blank">http://www.freitagmorgen.de</a> I think it's at least a year old and I can't find an email address for the author.)

I altered the filetypes array section on line 84 to add .png's but there's still no thumbnail generated.

Is this a limitation of the GD library? The script? Or .png files in general?

<div class='codetop'>CODE</div><div class='codemain'><?php

// #################################################################//

// #  script by WingNut                       http://www.freitagmorgen.de #//

// #                                                               #//

// #  this script has been published under the gnu public license  #//

// #  you may edit the script but never delete this comment! thx.  #//

// #################################################################//

// --begin editable region

// Root directory

$root_dir = ".";

// Thumbnail Columns

$columns = 7;

// Size of thumbnails in pixel

$thumbwidth = 100;

// Slideshow 0=no 1=yes

$slideshow = 0;

// --end editable region

//##################################################################//

// Do not change anything by now unless you know what you are doing!

?>

<html>

<head>

<title>Gallery</title>

<script type="text/javascript" src="slimbox/js/jquery-1.3.2.min.js"></script>

<script type="text/javascript" src="slimbox/js/slimbox2.js"></script>

<link rel="stylesheet" href="slimbox/css/slimbox2.css" type="text/css" media="screen" />

</head>

<body>

<?php

// --begin preprocessing

$phpself = $_SERVER['PHP_SELF'];

extract($_POST);

// filetypes

$filetypes = array("jpg", "jpeg", ".png");

$k = sizeof($filetypes);

for ($i=0; $i<$k; $i++)

{

  $filetypes[] = strtoupper($filetypes[$i]);

}

// extract local image folders

if (strpos($root_dir,'www')===0)

{

  $root_dir = 'http://'.$root_dir;

}

$local = parse_url($root_dir);

if (strpos($root_dir,'http://')===0)

{

  foreach (count_chars($phpself,1) as $i=>$val)

  {

    if (chr($i)=='/')

    {

          $root_dir = substr($local['path'],1);

      for ($j=1;$j<$val;$j++)

        $root_dir='../'.$root_dir;

    }

  }

  if (strpos($root_dir,$local['path'])===0)

  {

    $root_dir = ".";

  }

}

// scanning directory for folders and check if they contain image files

if (!is_dir($root_dir))

{

  printError("Couldn't find a root directory. Please specify a valid directory in EasyGallery.php.");

}

$root_handle = opendir($root_dir);

while ($dirname = readdir($root_handle))

{

  $var1 = strcmp($dirname,'.');

  $var2 = strcmp($dirname,'..');

  $var3 = is_dir($root_dir.'/'.$dirname);

  if (($var1!=0) && ($var2!=0) && ($var3==1))

  {

        $dir_handle = opendir($root_dir.'/'.$dirname);

        $postmp = 0;

        while ($filename = readdir($dir_handle))

        {

          for ($i=0;$i<sizeof($filetypes);$i++)

          {

        $postmp = strpos($filename, $filetypes[$i]);

                if ($postmp>0)

                {

                  $folders[] = $root_dir.'/'.$dirname;

                  break 2;

                }

          }

        }

        closedir($dir_handle);

  }

}

if (!$folders)

{

  printError("Searched folders don't contain any image! Please change the \$root_dir.");

}

// !!! if you don't want your folders in reverse order change rsort() to sort()

rsort($folders);

// set initial variable $ordner

if (!isset($ordner))

  $ordner = $folders[0];

// scanning directories for image files

if (is_dir($ordner)){

  $dir_handle = opendir($ordner);

  while ($filename = readdir($dir_handle))

  {

    for ($i=0; $i<sizeof($filetypes); $i++)

    {

      $pos = strpos($filename, $filetypes[$i]);

          $var1 = strcmp($filename,'.');

      $var2 = strcmp($filename,'..');

      $var3 = is_file($ordner.'/'.$filename);

      if (($var1 != 0) && ($var2 != 0) && ($var3 == 1) && ($pos > 0))

          {

            $files[] = $filename;

          }

          if ($filename=="thumbnails")

          {

            $thumbs = 1;

          }

    }

  }

  sort($files);

  $size = sizeof($files);

  closedir($dir_handle);

  closedir($root_handle);

}

else

{

  printError("No Folders found. Please copy your image folders to the location specified in the \$root_dir in EasyGallery.php.");

}

// --end preprocessing

?>

<?php

// --begin form

echo "<div class=\"form\">\n";

echo "<form name=\"fotoalbum\" method=\"post\" action=\"$phpself\">\n";

echo "<select class=\"form\" name=\"ordner\" onchange=\"document.fotoalbum.submit();\">\n";

while ($folder = each($folders))

{

  if ($ordner == $folder["value"])

  {

        echo "<option selected value=\"$ordner\">";

  }

  else

  {

    echo "<option value=\"";

        echo $folder["value"];

        echo "\">";

  }

  $text = $folder["value"];

  while (strrpos($text,"/"))

  {

    $text = substr($text, strrpos($text,"/")+1);

  }

  // !!! if you want to add special chars to your folders uncomment or add the lines you need

  // GERMAN

  //$text = str_replace("ae", "Ã¤", $text); // Replace all ae with Ã¤

  //$text = str_replace("oe", "Ã¶", $text); // Replace all oe with Ã¶

  //$text = str_replace("ue", "Ã¼", $text); // Replace all ue with Ã¼

  //$text = str_replace("sz", "ÃŸ", $text); // Replace all sz with ÃŸ

  //$text = str_replace("AE", "Ã„", $text); // Replace all AE with Ã„

  //$text = str_replace("OE", "Ã–", $text); // Replace all OE with Ã–

  //$text = str_replace("UE", "Ãœ", $text); // Replace all UE with Ãœ

  // SCANDINAVIAN

  //$text = str_replace("ae", "Ã¦", $text); // Replace all ae with Ã¦

  //$text = str_replace("oe", "Ã¸", $text); // Replace all oe with Ã¸

  //$text = str_replace("aa", "Ã¥", $text); // Replace all aa with Ã¥

  //$text = str_replace("AE", "Ã†", $text); // Replace all AE with Ã†

  //$text = str_replace("OE", "Ã˜", $text); // Replace all OE with Ã˜

  //$text = str_replace("AA", "Ã…", $text); // Replace all AA with Ã…

  $text = str_replace("_", " ", $text); // Replace all _ with SPACE

  echo $text;

  echo " </option>\n";

}

echo "</select>\n";

echo "</form>\n";

echo "</div>\n";

// --end form

// --begin print images

echo "<div class=\"form\">";

$xpos=8;

$ypos=6;

$count = 0;

$newthumbs = false;

$divheight = ceil(count($files)/$columns) * ($thumbwidth+6) + 6;

echo "<table height=$divheight width=100% cellspacing=0 cellpadding=0><tr valign=top><td>\n";

for ($y=0;$y<count($files);$y++)

{

  $tn_src = $ordner."/thumbnails/tn_".$files[$count];

  if (file_exists($tn_src))

  {

    $image = GetImageSize($tn_src);

    $image[0] -= 8;

    $image[1] -= 8;

        if ($image[0]==$image[1]){}

        elseif ($image[0]<$image[1]) $xpos += intval(($image[1]-$image[0])/2);

        else $ypos += intval(($image[0]-$image[1])/2);

    echo "<div id=\"livethumbnail\" style=\"left:".$xpos."px; top:".$ypos."px; position:relative; zIndex=1;\">";

    if($slideshow!=1){

          echo "<a href=\"".$ordner."/".$files[$count]."\" rel=\"lightbox-\"".$ordner.">";

        }

        else{

          echo "<a href=\"".$ordner."/".$files[$count]."\" rel=\"lightbox-\"".$ordner.">";

        }

    echo "<img src=\"$tn_src\" class=\"thumbnails\" alt=\"$files[$count]\" style=\"width:$image[0]; height:$image[1]; left:0px; top:0px; position:absolute; zIndex=1;\"></a></div>\n";

        if ($image[0]==$image[1]){}

        elseif ($image[0]<$image[1]) $xpos -= intval(($image[1]-$image[0])/2);

        else $ypos -= intval(($image[0]-$image[1])/2);

  }

  else

  {

        $modules = get_loaded_extensions();

        if(!in_array("gd", $modules)){

          printError("Your webserver doesn't provide the use of the GD library, which is required to create thumbnails. Please create and add your thumbnails manually.");

        }

        if(createthumb($ordner,$files[$count],$thumbwidth))

        {

          echo "tn_$files[$count] created.
";

          $newthumbs = true;

    }

        else

        {

          printError("Thumbnail creation failed.");

        }

  }

  $count++;

  if($count%$columns==0)

  {

    $ypos += $thumbwidth+6;

    $xpos = 8;

  }

  else

  {

    $xpos += $thumbwidth+6;

  }

}

if($newthumbs)

{

  echo "<script>location.reload()</script>";

}

echo "</td></tr></table>\n";

// dont even think about removing this link!

echo "</div>\n";

?>

</body>

<?php

function printError($text)

{

  echo "<div class=\"error\">";

  echo "<span class=\"content\">ERROR: $text</span>";

  echo "</div>";

  exit();

}

function createthumb($name,$file,$maxsize)

{

  $maxsize += 8;

  list($width, $height) = getimagesize("$name/$file");

  $width = min($width, $height);

  $tn = imagecreatetruecolor($maxsize, $maxsize);

  $image = imagecreatefromjpeg("$name/$file");

  imagecopyresampled($tn, $image, 0, 0, 0, 0, $maxsize, $maxsize, $width, $width);

  if(!is_dir("$name/thumbnails"))

  {

    mkdir ("$name/thumbnails", 0777);

  }

  imagejpeg($tn, "$name/thumbnails/tn_$file", 90);

  return true;

}

?>

<script>



</script>

</html></div>

Any idea's? Anyone know how to convert a .png (on upload) to .jpg?

Rob · January 2011

[edit2]
Maybe in that function try,

<div class='codetop'>CODE</div><div class='codemain'>var $isPng = false;

  if(!($image = imagecreatefromjpeg("$name/$file"))
{
    isPng = true;
    $image = imagecreatefrompng("$name/$file");
}

  imagecopyresampled($tn, $image, 0, 0, 0, 0, $maxsize, $maxsize, $width, $width);

  if(!is_dir("$name/thumbnails"))

  {

    mkdir ("$name/thumbnails", 0777);

  }

  if( $isPng )
  {
     imagepng($tn, "$name/thumbnails/tn_$file", 90);
  }
  else
  {
    imagejpeg($tn, "$name/thumbnails/tn_$file", 90);
  }

  return true;</div>

If it works, great, but it's a hack, and you'd have to do some similar change if you wanted to use this with GIFs or something.

[edit]
On further inspection, the .png shouldn't matter the way it's coded. Look here: function createthumb($name,$file,$maxsize)

I assume this is called when you've got your images found and you're ready to go. Some will be png, some will be jpg. But this function calls jpeg specific functions, so I suspect those would fail.

A fix would be to see if the png extension exists in the file name in this function, and if so, call the appropriate png functions instead.

----

A quick glance at this: "$filetypes = array("jpg", "jpeg", ".png");" Makes me think that your script would be looking for imageFile..png instead of imageFile.png. Try taking out the . in that array.

Any PHP Guru's?

Comments